Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): update type deps #1776

Merged
merged 3 commits into from Aug 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/pbts.js
Expand Up @@ -144,7 +144,7 @@ exports.main = function(args, callback) {
var output = [];
if (argv.main)
output.push(
"// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run types'.",
"// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run build:types'.",
""
);
if (argv.global)
Expand Down
2 changes: 1 addition & 1 deletion index.d.ts
@@ -1,4 +1,4 @@
// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run types'.
// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run build:types'.

export as namespace protobuf;

Expand Down
2 changes: 1 addition & 1 deletion tests/README.md
Expand Up @@ -5,7 +5,7 @@ It is essential that tests only use the cross-platform API that is also availabl
* Use `load`, not `loadSync`
* Use `Reader.create`, not `BufferReader`
* Use `Writer.create`, not `BufferWriter`
* It is safe to use `Long`
* It is safe to use `Long`, but TypeScript tests must import the type from `"long"`

If it's absolutely inevitable for your test case to use node-specific features, you can still use this pattern:

Expand Down
2 changes: 2 additions & 0 deletions tests/data/mapbox/vector_tile.d.ts
@@ -1,4 +1,6 @@
import * as $protobuf from "../../..";
import Long from "long";

export namespace vector_tile {

interface ITile {
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Expand Up @@ -2,6 +2,7 @@
"compilerOptions": {
"target": "ES5",
"experimentalDecorators": true,
"emitDecoratorMetadata": true
"emitDecoratorMetadata": true,
"esModuleInterop": true,
}
}