Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax requirements for generic conversion to TestCaseError #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented Jul 25, 2018

This permits using alternative error types which doesn't implement std::error::Error, like failure::Error directly in proptest blocks.

This is accomplished by relaxing the requirements on the blanket conversion mechanism to only require fmt::Display. Unfortunately this would cause TestCaseError to conflict with the blanket implementation, so it had to be reworked.

@AltSysrq
Copy link
Collaborator

The breaking change is pretty unfortunate, though this otherwise looks like a good thing to have. For now, I'm going to keep this open under consideration for the next time we have a breaking release.

@rex-remind101 rex-remind101 added the 2.0-wishlist This issue proposes breaking changes we'd like in a 2.0 release label Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-wishlist This issue proposes breaking changes we'd like in a 2.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants