docs - example of manual arbitrary impl #282
Conversation
cameron1024
changed the title
| x: i32, | ||
| y: i32, |
There was a problem hiding this comment.
Let's use 4 spaces per convention.
| any::<(i32, i32)>() // generate 2 arbitrary i32s | ||
| .prop_filter_map(|(lower, upper)| { | ||
| Range::new(lower, upper) | ||
| }) |
There was a problem hiding this comment.
As caveats, we should probably point to https://altsysrq.github.io/proptest-book/proptest-derive/modifiers.html#filter and also mention that a better implementation would be to swap upper for lower when upper < lower so that filtering is avoided.
There was a problem hiding this comment.
Good point. Do you think it's worth just changing the implementation? It feels weird to have the example and then a comment after saying "actually don't do it like this" when the fix is so trivial.
There was a problem hiding this comment.
Let's change the impl, but also, deriving is powerful enough to express the new impl easily.
|
@cameron1024 this looks close to done :) @Centril - i'm not sure how else to reach you or @AltSysrq , but it seems that you are the sole owners of proptest-derive still. would either of you be able to update the owners to include the publish team? thanks! |
Added. |
Adds a section to the book for manually implementing
Arbitrary, addresses #252