Use const generics to remove 32 element array size restriction #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace macro generated code with const-generic code. `uniformN` methods are still implemented to keep backwards compatibility.
|
Were you interested in taking this PR @AltSysrq? I'd love to be able to use const generics for something I'm building. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the macro generated code for small arrays (with less than 32 elements) with const-generic code that have no size restrictions. I'm not sure if this is a desired feature, but I found it could be useful to me so I gave a shot at trying to implement it. The
uniform{1..32}functions are still generated as "proxy functions" in order to keep backwards compatibility.