New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 6 #1815
Allow Symfony 6 #1815
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1815 +/- ##
=========================================
Coverage 87.83% 87.83%
Complexity 7836 7836
=========================================
Files 281 281
Lines 22748 22748
=========================================
Hits 19981 19981
Misses 2767 2767
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
184197b
to
d602d8e
Compare
Now psalm job is fixed, I get 11 errors related to added return types in Symfony 6. I checked those errors and are all enforcing the 5.x behavior. Should I add those errors to the baseline to keep the current behavior? |
I guess so. In a next step we need to get rid of at least v3 here. |
Lets focus on getting this merged first, so we can easier then finalize also the v3 removal PR. |
I did some cleanup in
|
This allows Symfony 6 components.
This is a draft ATM because I only ran some tests locally.
CI failure seems unrelated. See composer/composer#10387.