Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 6 #1815

Merged
merged 3 commits into from Jan 4, 2022
Merged

Allow Symfony 6 #1815

merged 3 commits into from Jan 4, 2022

Conversation

fbourigault
Copy link
Contributor

@fbourigault fbourigault commented Dec 23, 2021

This allows Symfony 6 components.

This is a draft ATM because I only ran some tests locally.

CI failure seems unrelated. See composer/composer#10387.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #1815 (d602d8e) into master (d9817c1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1815   +/-   ##
=========================================
  Coverage     87.83%   87.83%           
  Complexity     7836     7836           
=========================================
  Files           281      281           
  Lines         22748    22748           
=========================================
  Hits          19981    19981           
  Misses         2767     2767           
Flag Coverage Δ
5-max 87.83% <100.00%> (ø)
7.4 87.83% <100.00%> (ø)
agnostic 68.54% <0.00%> (ø)
mysql 70.53% <100.00%> (ø)
pgsql 70.42% <100.00%> (ø)
sqlite 68.46% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pel/Generator/Command/Console/Input/ArrayInput.php 44.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9817c1...d602d8e. Read the comment docs.

@fbourigault fbourigault marked this pull request as ready for review January 3, 2022 10:45
@fbourigault
Copy link
Contributor Author

Now psalm job is fixed, I get 11 errors related to added return types in Symfony 6.

I checked those errors and are all enforcing the 5.x behavior.

Should I add those errors to the baseline to keep the current behavior?

@dereuromark
Copy link
Contributor

I guess so.
They are not functionally relevant, are they?

In a next step we need to get rid of at least v3 here.
That might also simplify a few things.

@dereuromark
Copy link
Contributor

Lets focus on getting this merged first, so we can easier then finalize also the v3 removal PR.

@fbourigault
Copy link
Contributor Author

I did some cleanup in tests/composer:

  • I removed composer-php8.json as it seems unused.
  • I fixed php version requirement.
  • I removed php 7.3 polyfill.
  • I bumped PHPUnit requirement to 9.5+.

@dereuromark dereuromark merged commit 5930bad into propelorm:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants