Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add PHP8 to travis / PHP8 support #413

Merged
merged 16 commits into from Jan 7, 2021
Merged

[7.x] Add PHP8 to travis / PHP8 support #413

merged 16 commits into from Jan 7, 2021

Conversation

fritz-gerneth
Copy link
Contributor

@fritz-gerneth fritz-gerneth commented Dec 5, 2020

Changes:

  • Updated the README badges to link to the correct branch for this version
  • Use ProphesizeTrait, prophesize integration has been moved into its own package phpspec/prophecy-phpunit
  • Replaced calls to assertInternalType() with new assertions ( old ones have been removed )
  • assertRegExp is deprecated and replaced
  • Annotated a few tests with @medium that were running longer than 1 second and thus being stopped
  • Update travis
  • Fix at deprecation warnings in phpunit
  • Update Doc-Header for 2021

@enumag enumag changed the title Add PHP8 to travis / PHP8 support Add PHP8 to travis / PHP8 support Dec 5, 2020
composer.json Outdated Show resolved Hide resolved
@sandrokeil
Copy link
Member

Maybe we should switch to GitHub actions.

Co-authored-by: Jáchym Toušek <enumag@gmail.com>
@fritz-gerneth
Copy link
Contributor Author

With PHP8 not working on Travis there is one apparent problem - other dependencies need to support PHP8 too. For the prooph/* components this probably is realistic. The biggest concern is about phpunit though - the minimum version to use would be phpunit@9 - requiring php > 7.3. That'd bump the version requirements of the prooph packages to 7.3 as well.

@sandrokeil
Copy link
Member

I see no problem to increase the minimum PHP version if needed. Maybe rector can be used to make the code automatically compatible if needed. But indeed, some work is needed.

@fritz-gerneth
Copy link
Contributor Author

Bump the minor version and make it a 7.5 version / branch then?

@sandrokeil
Copy link
Member

We already have version 7.5, so it will be 7.6. What do you think @codeliner @prolic ? Should we also increase the PHP minimum version to 7.4? I see no reason to support PHP 7.3 anymore in this new version.

@@ -24,7 +24,7 @@
"minimum-stability": "dev",
"prefer-stable": true,
"require": {
"php": "^7.1",
"php": "^7.1 || ^8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set PHP minimum version to ^7.4 for the new minor version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.3 is still supported until end of next year. PHPUnit 9 supports 7.3 and 8 . Any specific reason to jump to 7.4 right away?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, we can stick to PHP 7.3, because we don‘t want to use new features.

@prolic
Copy link
Member

prolic commented Dec 8, 2020

good for me

@fritz-gerneth
Copy link
Contributor Author

Inherently this is blocked by prooph/php-cs-fixer-config#8 / PHP-CS to support PHP8.

@enumag
Copy link
Member

enumag commented Dec 15, 2020

Note that php-cs-fixer (while it's not entirely ready to handle all PHP 8 features) no longer blocks installation under php 8. So in my opinion prooph/php-cs-fixer-config#8 can be merged now.

@sandrokeil
Copy link
Member

I've updated prooph/php-cs-fixer-config#8 to support PHP ^7.1 || ^8.0 too.

@fritz-gerneth
Copy link
Contributor Author

Awesome. I'll update the prooph packages then :)

@fritz-gerneth fritz-gerneth changed the title Add PHP8 to travis / PHP8 support [7.x] Add PHP8 to travis / PHP8 support Dec 17, 2020
@prolic
Copy link
Member

prolic commented Dec 21, 2020

see https://github.com/prooph/php-cs-fixer-config/releases/tag/v0.4.0

@coveralls
Copy link

coveralls commented Jan 5, 2021

Coverage Status

Coverage decreased (-0.4%) to 99.07% when pulling 3ff1c61 on funct:7.x into 9b74792 on prooph:7.x.

@fritz-gerneth fritz-gerneth marked this pull request as ready for review January 5, 2021 09:25
@fritz-gerneth
Copy link
Contributor Author

This should be good for review now :)

@fritz-gerneth fritz-gerneth mentioned this pull request Jan 7, 2021
Copy link
Member

@prolic prolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, just 2 minor notes.

|---------|------------|---------------|---------------|
| 5.x | EOL | \>= 5.5 | EOL |
| 6.x | Maintained | \>= 5.5 | 3 Dec 2017 |
| 7.5.x | Latest | \>= 7. | active |
Copy link
Member

@prolic prolic Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still requires 7.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took care of this myself.

@prolic prolic merged commit 3ff1c61 into prooph:7.x Jan 7, 2021
@prolic
Copy link
Member

prolic commented Jan 7, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants