Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ramsey/uuid v4.x #120

Closed
wants to merge 1 commit into from
Closed

Allow ramsey/uuid v4.x #120

wants to merge 1 commit into from

Conversation

enumag
Copy link
Member

@enumag enumag commented Mar 23, 2020

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 634

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.722%

Totals Coverage Status
Change from base Build 616: 0.0%
Covered Lines: 3231
Relevant Lines: 4771

💛 - Coveralls

@enumag enumag marked this pull request as ready for review March 23, 2020 13:47
@enumag enumag requested a review from prolic March 23, 2020 13:47
@prolic
Copy link
Member

prolic commented Mar 23, 2020

@enumag Why not pin to 4.0 directly? I didn't check this new major release so far. What's the difference?

@prolic
Copy link
Member

prolic commented Mar 23, 2020

Looking at https://github.com/ramsey/uuid/releases/tag/4.0.0, I think pinning to 4.0 is the way to go. Thoughts?

@enumag
Copy link
Member Author

enumag commented Mar 23, 2020

I think that locking it at v4.0 might make sense when solving #119 since that might require using more of ramsey's features. But until then ramsey/uuid is just a minor dependency for us and the bc breaks don't affect us. Locking it at v4.0 needlessly would only cause unnecessary dependency conflicts for our users who might have dependencies on ramsey/uuid through some other libraries. It kinda depends on when you're planning on working on #119 but since you're busy lately I'm treating it as something that may or may not happen soon so I'm not including it into my considerations here.

@prolic
Copy link
Member

prolic commented Apr 7, 2020

I tried creating Guid's using 4.0 of this ramsey-lib and ended up creating an issue: ramsey/uuid#306

@prolic
Copy link
Member

prolic commented Apr 30, 2020

solved via prooph/event-store#387

@prolic prolic closed this Apr 30, 2020
@prolic prolic deleted the feature/update-ramsey-uuid branch April 30, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants