Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UUID1 / UUID5, ... #119

Closed
prolic opened this issue Mar 17, 2020 · 3 comments
Closed

Support UUID1 / UUID5, ... #119

prolic opened this issue Mar 17, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@prolic
Copy link
Member

prolic commented Mar 17, 2020

No description provided.

@prolic prolic added the enhancement New feature or request label Mar 17, 2020
@BoyeMagnus
Copy link

Would it be possible to support just an interface instead of a class? That way people can provide their own implementations?

@prolic
Copy link
Member Author

prolic commented Mar 17, 2020 •
edited

Maybe, but I need to make sure it's a valid GUID, otherwise you'll run into problems. Using Ramsey in PHP, you need to enable the GuidStringCodec in the FeatureSet. That's why I thought initially that a class that doesn't allow you the freedom to break the event store is the better solution.
I need to have a look, because I think different types of UUID's are a valid feature requirement.

@enumag enumag mentioned this issue Mar 23, 2020
Closed
@prolic
Copy link
Member Author

prolic commented Apr 7, 2020

Am I stupid?

ramsey/uuid#306

@prolic prolic closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prolic @BoyeMagnus