-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config and registry to processed source if the methods exist #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renatolond can you specifically add 1.38.0
to this line so that we check this? You'll probably need to add to the excludes as well for Ruby 2.3 and 2.4.
I'm also wondering why I don't get an option to trigger the CI run on this PR 🤔
Sure, done! It's weird about the CI, I already saw the option of "allow run" for new contributors on some of my projects, but not showing at all is odd 🤔 |
@renatolond can you do a rebase or something? I triggered a run manually, apparently scheduled actions got suspended on this repo, which were supposed to inform me about regressions -- another fun thing to research 🙈 |
f603a85
to
23a21f2
Compare
@ashkulz Sure, done! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a typo, @renatolond 🙂
23a21f2
to
348f6c5
Compare
Fixes issue with rubocop > 1.38.x
348f6c5
to
9678fe6
Compare
Thanks for the contribution, @renatolond! I'll push up a release by EOD. |
Thank you, @ashkulz 🎉 |
Released to RubyGems: https://rubygems.org/gems/pronto-rubocop/versions/0.11.3 |
Fixes issue with rubocop > 1.38.x
It seems that rubocop/rubocop#10987 introduced registry and config to new versions of rubocop which were not there before.
Without those, rubocop still works, but it raises a lot of errors for some files.
I added the registry and source like in the rubocop code if the ProcessedSource responds to it, so I'm hoping it won't break compatibility with older rubocop versions.
This fixes #76