Skip to content

Commit

Permalink
block support for RuboCop 0.84.0
Browse files Browse the repository at this point in the history
This was the first version to use rubocop-ast, and unfortunately
the dependency is loose enough that rubocop-ast versions >= 0.7.0
are allowed, which cause require 'rubocop' to fail with

  NoMethodError:
    undefined method `join' for #<Set: {:==, :===, :!=, :<=, :>=, :>, :<}>
  # rubocop-0.84.0/lib/rubocop/cop/style/redundant_conditional.rb:57:in `<class:RedundantConditional>'

This is due to rubocop/rubocop-ast#22
and it's too much effort to pin that dependency and hence easier
to just block the version instead.
  • Loading branch information
ashkulz committed Feb 13, 2021
1 parent 7e19460 commit d79bff6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pronto-rubocop.gemspec
Expand Up @@ -33,7 +33,7 @@ Gem::Specification.new do |s|
s.require_paths = ['lib']

s.add_runtime_dependency('pronto', '~> 0.11.0')
s.add_runtime_dependency('rubocop', '>= 0.63.1', '< 1.0')
s.add_runtime_dependency('rubocop', '>= 0.63.1', '!= 0.84.0', '< 1.0')
s.add_development_dependency('rake', '~> 12.0')
s.add_development_dependency('rspec', '~> 3.4')
s.add_development_dependency('rspec-its', '~> 1.2')
Expand Down

0 comments on commit d79bff6

Please sign in to comment.