Skip to content

Commit

Permalink
fix support for RuboCop 0.84.0 and 0.85.x
Browse files Browse the repository at this point in the history
These were the first versions to use rubocop-ast, and unfortunately
the dependency is loose enough that rubocop-ast versions >= 0.7.0
are allowed, which cause require 'rubocop' to fail with

  NoMethodError:
    undefined method `join' for #<Set: {:==, :===, :!=, :<=, :>=, :>, :<}>
  in rubocop-0.84.0/lib/rubocop/cop/style/redundant_conditional.rb:57:in `<class:RedundantConditional>'

This is due to rubocop/rubocop-ast#22
so just block those versions directly. This has the unfortunate
side effect of requiring rubocop-ast for older versions which
don't require it.
  • Loading branch information
ashkulz committed Feb 13, 2021
1 parent 7e19460 commit 18baa3c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pronto-rubocop.gemspec
Expand Up @@ -34,6 +34,7 @@ Gem::Specification.new do |s|

s.add_runtime_dependency('pronto', '~> 0.11.0')
s.add_runtime_dependency('rubocop', '>= 0.63.1', '< 1.0')
s.add_runtime_dependency('rubocop-ast', '>= 0.6.0', '!= 0.7.0', '!= 0.7.1', '!= 0.8.0')
s.add_development_dependency('rake', '~> 12.0')
s.add_development_dependency('rspec', '~> 3.4')
s.add_development_dependency('rspec-its', '~> 1.2')
Expand Down

0 comments on commit 18baa3c

Please sign in to comment.