chore: Generate dashboard configmap from separate json files #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
force-pushed
the
generate-dashboards
branch
from
df72397
to
afe6507
Compare
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
ArthurSens
force-pushed
the
generate-dashboards
branch
from
afe6507
to
5ffb6e1
Compare
ArthurSens
commented
Apr 26, 2024
| @@ -1573,36 +1573,36 @@ data: | |||
| "steppedLine": false, | |||
| "targets": [ | |||
| { | |||
| "expr": "node_memory_MemTotal_bytes{job=\"node-exporter\",namespace=\"prombench-[[pr-number]]\",node=~\"(test+).*\"}", | |||
| "expr": "node_memory_MemTotal_bytes{job=\"node-exporter\",namespace=\"prombench-${prNumber}\",node=~\"(test+).*\"}", | |||
There was a problem hiding this comment.
I don't understand why we're seeing this diff 🤨
In master I see this line with ${prNumber}
Same thing for all other changes in this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing the release for v2.52, I wanted to extend the prombench dashboard with more information that was needed to evaluate the release.
In the process of doing the contribution here, I realized how painful it is to contribute code to a json nested inside a configmap yaml.
I want to make this process easier first, and contribute the new dashboard panel after :)
Fix #420