Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to exporter-toolkit v0.8.1 #810

Merged

Conversation

DaAwesomeP
Copy link
Contributor

This pull updates the snmp_exporter to use the latest version of exporter-toolkit and includes the new flag methods.

Associated exporter-toolkit pull: prometheus/exporter-toolkit#95

Similar node_exporter pull: prometheus/node_exporter#2393

cc @SuperQ @RichiH

Signed-off-by: Perry Naseck <git@perrynaseck.com>
@DaAwesomeP
Copy link
Contributor Author

DaAwesomeP commented Oct 22, 2022

Unsure why make mibs step failed: https://app.circleci.com/pipelines/github/prometheus/snmp_exporter/814/workflows/a5231587-d71f-4303-8faf-6affd952e78f/jobs/3606/parallel-runs/0/steps/0-104

May someone trigger a re-run? I can trigger with a force-push.

Signed-off-by: Perry Naseck <git@perrynaseck.com>
@DaAwesomeP DaAwesomeP force-pushed the DaAwesomeP-update-exporter-toolkit-v0.8.1 branch from d83cdef to 1c3c388 Compare October 22, 2022 17:12
@DaAwesomeP
Copy link
Contributor Author

Ah, appears to be issue #809, not caused by this pull.

@SuperQ
Copy link
Member

SuperQ commented Oct 26, 2022

I fixed the make mibs issue.

@SuperQ SuperQ merged commit 9e73705 into prometheus:main Oct 26, 2022
SuperQ added a commit that referenced this pull request Nov 21, 2022
* [CHANGE] Update to exporter-toolkit v0.8.1 (#810)
* [FEATURE] Support chained lookups in the generator (#757)
* [ENHANCEMENT] Add per-SNMP packet statistics. (#656)
* [ENHANCEMENT] Add support for aes192c and aes256c privacy protocol (#657)
* [ENHANCEMENT] Support responding from different source address (#702)
* [BUGFIX] Fixes dropped context passing (#634)
* [BUGFIX] Add version flag (#717)
* [BUGFIX] Fix retries in generator (#786)

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Nov 21, 2022
SuperQ added a commit that referenced this pull request Nov 21, 2022
* [CHANGE] Update to exporter-toolkit v0.8.1 (#810)
* [FEATURE] Support chained lookups in the generator (#757)
* [ENHANCEMENT] Add per-SNMP packet statistics. (#656)
* [ENHANCEMENT] Add support for aes192c and aes256c privacy protocol (#657)
* [ENHANCEMENT] Support responding from different source address (#702)
* [BUGFIX] Fixes dropped context passing (#634)
* [BUGFIX] Add version flag (#717)
* [BUGFIX] Fix retries in generator (#786)

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Nov 22, 2022
* [CHANGE] Update to exporter-toolkit v0.8.1 (#810)
* [FEATURE] Support chained lookups in the generator (#757)
* [ENHANCEMENT] Add per-SNMP packet statistics. (#656)
* [ENHANCEMENT] Add support for aes192c and aes256c privacy protocol (#657)
* [ENHANCEMENT] Support responding from different source address (#702)
* [BUGFIX] Fixes dropped context passing (#634)
* [BUGFIX] Add version flag (#717)
* [BUGFIX] Fix retries in generator (#786)

Signed-off-by: SuperQ <superq@gmail.com>

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants