Add Schneider_PM55XX MIB to downloads for SNMP generator #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbegyn
force-pushed
the
add-schneider-pm5xx-mib
branch
2 times, most recently
from
d764c20
to
62be456
Compare
generator/Makefile
Outdated
| @curl $(CURL_OPTS) -o $(TMP) $(SCHNEIDER_PM55XX_URL) | ||
| @unzip -j -d $(MIBDIR) $(TMP) PM5560_PM5563_v2.1.0/SchneiderPM55xx_V01_13.mib | ||
| # Workaround invalid character in Schneider MIB | ||
| @sed -i 's/_//g' $(MIBDIR)/SchneiderPM55xx_V01_13.mib |
There was a problem hiding this comment.
Is this still necessary, given that we support mibopts (#873) and you can simply allow those characters by adding mibopt "u" ?
There was a problem hiding this comment.
Ah, totally slipped my mind that is an option. Switched it out in favor of your idea. The --snmp.mibopts u works perfectly.
There was a problem hiding this comment.
Hmm, I'm not sure I'm happy with adding a MIB that requires custom mibopts. Perhaps we should adjust the generator default mibopts?
Or maybe get Schneider to fix their MIB. Cisco had some similar issues in the AIRESPACE-WIRELESS-MIB that I got them to fix. Teach them about smilint 😁
Signed-off-by: Francis Begyn <francis@begyn.be>
fbegyn
force-pushed
the
add-schneider-pm5xx-mib
branch
from
62be456
to
5c043ab
Compare
I missed the `--snmp.mibopts` before. By using `--snmp.mibopts u`, this error can be prevented and it offers a much more robust way to handle the problem than using `sed` in a makefile. Signed-off-by: Francis Begyn <francis@begyn.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple addition of the Schneider MIB for the PM55XX device series.