Update dependencies #284
Merged
Update dependencies #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add a go version line, as this tends to be added automatically by tools, but then it adds the Go version currently used, while Pushgateway should just build fine with older Go versions. (Specifying anything earlier than Go1.11 doesn't make sense, though, as Go modules weren't supported previously.) Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
|
We still need to update golang-builder to Go1.13. |
|
golangci-lint is broken with Go 1.13 (see golangci/golangci-lint#652 and golangci/golangci-lint#659). We also need prometheus/golang-builder#76 which I haven't merged yet because of that same issue. |
|
That explains it. Thanks. So we'll have more things waiting for getting unblocked. |
Signed-off-by: beorn7 <beorn@grafana.com>
|
Also needed to update the vendored files. |
|
@simonpasquier build is green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a go version line, as this tends to be added automatically
by tools, but then it adds the Go version currently used, while
Pushgateway should just build fine with older Go versions. (Specifying
anything earlier than Go1.11 doesn't make sense, though, as Go modules
weren't supported previously.)
Signed-off-by: beorn7 beorn@grafana.com