Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fsnotify to v1.4.9 #8244

Closed
wants to merge 1 commit into from
Closed

Conversation

johejo
Copy link
Contributor

@johejo johejo commented Dec 1, 2020

Migrate from gopkg.in to github.com

Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com

Migrate from gopkg.in to github.com

Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
@brian-brazil
Copy link
Contributor

Why are you changing where we're taking the package from? The gopkg.in version appears to be official.
Also is there some particular bug or other reason you're looking to bump this?

@johejo
Copy link
Contributor Author

johejo commented Dec 1, 2020

fsnotify migrated from gopkg.in to github.com for go modules.
fsnotify/fsnotify#309

Modules newer than v1.4.8 do not exist in gopkg.in.

Some fixes

@brian-brazil
Copy link
Contributor

Modules newer than v1.4.8 do not exist in gopkg.in.

https://gopkg.in/fsnotify/fsnotify.v1 has 1.4.9.

fsnotify/fsnotify#219 fsnotify/fsnotify#273

We don't fork, so these aren't relevant to Prometheus.

@johejo
Copy link
Contributor Author

johejo commented Dec 1, 2020

ok, I understand. close

@johejo johejo closed this Dec 1, 2020
@johejo
Copy link
Contributor Author

johejo commented Dec 1, 2020

v1.4.9 doesn't exist in pkg.go.dev, so it seems that I made a mistake.
https://pkg.go.dev/gopkg.in/fsnotify/fsnotify.v1?tab=versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants