Update golangci-lint

[SuperQ]

• Update to latest release.
• Remove install -d workaround0.

Signed-off-by: Ben Kochie superq@gmail.com

[SuperQ]

Some new errors:

discovery/openstack/hypervisor_test.go:62:24: SA5011: possible nil pointer dereference (staticcheck)
  testutil.Assert(t, tg.Targets != nil, "")
                        ^
discovery/openstack/hypervisor_test.go:63:31: SA5011: possible nil pointer dereference (staticcheck)
  testutil.Equals(t, 2, len(tg.Targets))
                               ^
discovery/triton/triton_test.go:90:24: SA5011: possible nil pointer dereference (staticcheck)
  testutil.Assert(t, td.client != nil, "")
                        ^
promql/engine.go:1442:16: SA6002: argument should be pointer-like to avoid allocations (staticcheck)
  pointPool.Put(p[:0])
                ^
tsdb/head.go:551:19: SA6002: argument should be pointer-like to avoid allocations (staticcheck)
      seriesPool.Put(v)
                     ^
tsdb/head.go:584:20: SA6002: argument should be pointer-like to avoid allocations (staticcheck)
      samplesPool.Put(v)
                      ^

[roidelapluie]

cc @pracucci what do you think about the TSDB ones?

[bwplotka]

It's red herring as it's bytes slice IMO, but we can make it explicit pointer if needed (:

[pracucci]

cc @pracucci what do you think about the TSDB ones?

There's already a comment //lint:ignore SA6002 relax staticcheck verification. but looks the directive is now ignored? Not sure what's happening.

[mneverov]

There is a bug in golangci-lint which causes //lint:ignore SA6002 ... be ignored.

[SuperQ]

Closing this until the upstream issue is fixed.