Cut v2.11.0-rc.0 #5729

brancz · 2019-07-02T16:14:04Z

Opening this already as the release is targeted for tomorrow.

@brian-brazil @beorn7 @gouthamve @juliusv @simonpasquier @krasi-georgiev @cstyan @codesome

brian-brazil

TSDB changes should also be included, and there's at least one PR we still want to get in.

brian-brazil · 2019-07-02T17:22:16Z

CHANGELOG.md

+* [ENHANCEMENT] Sanitize HTML output. #5665
+* [ENHANCEMENT] Remote-write allocation improvements. #5614
+* [ENHANCEMENT] Query performance improvement: Efficient iteration and search in HashForLabels and HashWithoutLabels. #5707
+* [ENHANCEMENT] Prometheus Monitoring Mixin for Prometheus itself. #4474


This is not a feature in the binaries

brian-brazil · 2019-07-02T17:22:30Z

CHANGELOG.md

+* [ENHANCEMENT] Add storage warnings to LabelValues and LabelNames API results. #5673
+* [ENHANCEMENT] Add 'code' label to HTTP metrics. #5640
+* [ENHANCEMENT] Enable openbsd/arm build. #5696
+* [ENHANCEMENT] Sanitize HTML output. #5665


This has no user-visible effect

brian-brazil · 2019-07-02T17:22:42Z

CHANGELOG.md

+* [FEATURE] Add $externalLabels for alert unit tests. #5608
+* [FEATURE] Allows globs for rules when unit testing. #5595
+* [FEATURE] Add option to use Alertmanager API v2. #5482
+* [FEATURE] Added humanizePercentage formatting to templates. #5670


brian-brazil · 2019-07-02T17:23:06Z

CHANGELOG.md

+## v2.11.0-rc.0 / 2019-07-03
+
+* [CHANGE] Remove max_retries from queue_config. #5649
+* [FEATURE] Add $externalLabels for alert unit tests. #5608


Not quite, users can now provide external_labels

I think this and the next are enhancements, as they're building on existing features rather than being something brand new

brian-brazil · 2019-07-02T17:25:39Z

CHANGELOG.md

+* [ENHANCEMENT] Remote-write allocation improvements. #5614
+* [ENHANCEMENT] Query performance improvement: Efficient iteration and search in HashForLabels and HashWithoutLabels. #5707
+* [ENHANCEMENT] Prometheus Monitoring Mixin for Prometheus itself. #4474
+* [ENHANCEMENT] Allow injection of arbitrary headers in promtool. #4389


The PR title indicates this is intended for auth, and putting secrets on the commandline is not good practice.

Do you want me to change anything here? (I agree with your statement, but this is still what was added factually no?)

cstyan · 2019-07-02T19:49:53Z

CHANGELOG.md

@@ -1,3 +1,23 @@
+## v2.11.0-rc.0 / 2019-07-03
+
+* [CHANGE] Remove max_retries from queue_config. #5649


is it worth mentioning that it was removed because the value wasn't being used anymore? I guess giving the PR number is enough

krasi-georgiev · 2019-07-03T00:33:01Z

TSDB changes should also be included, and there's at least one PR we still want to get in.

yeah I can do the tsdb update, but there is the snapshot bug that might need a bit more work.

brancz · 2019-07-03T07:25:04Z

Do we want to cut an RC knowing @krasi-georgiev's comment and prometheus-junkyard/tsdb#646 ?

codesome · 2019-07-03T07:31:29Z

There are some fixes in tsdb (like prometheus-junkyard/tsdb#623, prometheus-junkyard/tsdb#637) and some enhancements (not critical). I am not sure if this release should be blocked by them.

simonpasquier · 2019-07-03T07:48:06Z

CHANGELOG.md

+* [FEATURE] Add option to use Alertmanager API v2. #5482
+* [FEATURE] Added humanizePercentage formatting to templates. #5670
+* [FEATURE] Include InitContainers in Kubernetes Service Discovery. #5598
+* [ENHANCEMENT] Reduce allocations in in PromQL aggregations. #5641


s/in in/in/

simonpasquier · 2019-07-03T07:49:07Z

CHANGELOG.md

+* [ENHANCEMENT] Prometheus Monitoring Mixin for Prometheus itself. #4474
+* [ENHANCEMENT] Allow injection of arbitrary headers in promtool. #4389
+* [BUGFIX] resolve race condition in maxGauge. #5647
+* [BUGFIX] Fix zk connection leak. #5675


s/zk/ZooKeeper/

brancz · 2019-07-03T09:54:05Z

I'm hearing for 2.11 we're not doing a tsdb update, please confirm. I've addressed all other comments I believe.

brian-brazil · 2019-07-03T09:57:16Z

We should always do a TSDB update.

krasi-georgiev · 2019-07-03T12:13:47Z

The TSDB head snapshoting bugfix can be saliently improved, but decided it is not a blocker so it is already merged and @bwplotka is updating tsdb in #5733

this update will also add the optional WAL compression. see : prometheus-junkyard/tsdb#609 (comment)

brancz · 2019-07-03T15:07:45Z

Still waiting on #5592, but I think this is ready for re-review.

brancz · 2019-07-03T15:41:21Z

TSDB is updated.

CHANGELOG.md

brian-brazil · 2019-07-03T15:52:08Z

CHANGELOG.md

+
+* [CHANGE] Remove `max_retries` from queue_config (it has been unused since rewriting remote-write to utilize the write-ahead-log). #5649
+* [CHANGE] The meta file `BlockStats` no longer holds size information. This is now dynamically calculated and kept in memory. It also includes the meta file size which was not included before. tsdb#637
+* [CHANGE] Create new clean segment when starting the WAL. tsdb#608


This is not a breaking change, I'm not sure it's even worth mentioning - ENHANCEMENT a most.

brian-brazil · 2019-07-03T15:53:58Z

CHANGELOG.md

+* [ENHANCEMENT] Remote-write allocation improvements. #5614
+* [ENHANCEMENT] Query performance improvement: Efficient iteration and search in HashForLabels and HashWithoutLabels. #5707
+* [ENHANCEMENT] Allow injection of arbitrary headers in promtool. #4389
+* [ENHANCEMENT] Allow specifying `$externalLabels` in alert unit tests. #5608


This was already possible, it's allowing setting external_labels which has changed.

simonpasquier · 2019-07-03T16:04:10Z

LGTM albeit Brian's comments.

brancz · 2019-07-04T07:54:27Z

Updated the date to today's date, and I believe I've addressed all comments. Please re-review 🙂 .

simonpasquier · 2019-07-04T08:00:01Z

CHANGELOG.md

@@ -1,3 +1,34 @@
+## v2.11.0-rc.0 / 2019-07-04


s/v2.11.0-rc.0/2.11.0-rc.0/

brian-brazil · 2019-07-04T08:52:24Z

CHANGELOG.md

+* [ENHANCEMENT] Allow injection of arbitrary headers in promtool. #4389
+* [ENHANCEMENT] Allow passing `external_labels` in alert unit tests groups. #5608
+* [ENHANCEMENT] Allows globs for rules when unit testing. #5595
+* [ENHANCEMENT] Improved atomicity of .tmp block replacement during compaction for usual case. tsdb#636


This sounds like a bugfix

Moved to bugfix section.

brian-brazil · 2019-07-04T08:52:51Z

CHANGELOG.md

+* [ENHANCEMENT] Optimize queries using regexp for set lookups. tsdb#602
+* [BUGFIX] resolve race condition in maxGauge. #5647
+* [BUGFIX] Fix ZooKeeper connection leak. #5675
+* [BUGFIX] Re-encode all head chunks at compaction that are open (being appended to) or outside the Maxt block range. This avoids writing out corrupt data. It happens when snapshotting with the head included. tsdb#641


This is duplicate with 4 down

Indeed, removed.

Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>

brian-brazil · 2019-07-04T09:16:54Z

👍

bwplotka · 2019-07-04T12:06:12Z

Awesome!

brancz · 2019-07-04T13:45:34Z

/benchmark 2.10.0

prombot · 2019-07-04T13:45:36Z

@brancz: Welcome to Prometheus Benchmarking Tool.

The two prometheus versions that will be compared are pr-5729 and v2.10.0

The logs can be viewed at the links provided in the GitHub check blocks at the end of this conversation

After successfull deployment, the benchmarking metrics can be viewed at :

prometheus-meta - label {namespace="prombench-5729"}
grafana - template-variable "pr-number" : 5729

The Prometheus servers being benchmarked can be viewed at :

PR - prombench.prometheus.io/5729/prometheus-pr
v2.10.0 - prombench.prometheus.io/5729/prometheus-release

To stop the benchmark process comment /benchmark cancel .

In response to this:

/benchmark 2.10.0

If you have questions or suggestions related to my behavior, please file an issue against the prometheus/prombench repository.

krasi-georgiev · 2019-07-08T13:40:35Z

/benchmark cancel

krasi-georgiev · 2019-07-08T13:47:00Z

/benchmark 2.10.0

running a new test with the updated builder to use golang 1.12.5

prombot · 2019-07-08T13:47:03Z

@krasi-georgiev: Welcome to Prometheus Benchmarking Tool.

The two prometheus versions that will be compared are pr-5729 and v2.10.0

The logs can be viewed at the links provided in the GitHub check blocks at the end of this conversation

After successfull deployment, the benchmarking metrics can be viewed at :

prometheus-meta - label {namespace="prombench-5729"}
grafana - template-variable "pr-number" : 5729

The Prometheus servers being benchmarked can be viewed at :

PR - prombench.prometheus.io/5729/prometheus-pr
v2.10.0 - prombench.prometheus.io/5729/prometheus-release

To stop the benchmark process comment /benchmark cancel .

In response to this:

/benchmark 2.10.0

running a new test with the updated builder to use golang 1.12.5

If you have questions or suggestions related to my behavior, please file an issue against the prometheus/prombench repository.

brancz · 2019-07-09T08:11:09Z

Benchmarks not showing any regression. No bugs reported, so moving forward with cutting final release of v2.11.0.

/benchmark cancel

brancz force-pushed the cut-2.11.0-rc.0 branch from 3f0ac9f to dc7eb24 Compare July 2, 2019 16:14

brian-brazil reviewed Jul 2, 2019

View reviewed changes

cstyan reviewed Jul 2, 2019

View reviewed changes

simonpasquier reviewed Jul 3, 2019

View reviewed changes

brancz force-pushed the cut-2.11.0-rc.0 branch from dc7eb24 to 58098ec Compare July 3, 2019 09:53

brancz force-pushed the cut-2.11.0-rc.0 branch from 58098ec to 54d22a9 Compare July 3, 2019 15:04

simonpasquier reviewed Jul 3, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

simonpasquier reviewed Jul 3, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

brancz force-pushed the cut-2.11.0-rc.0 branch from 54d22a9 to 4a5c466 Compare July 3, 2019 15:49

brian-brazil reviewed Jul 3, 2019

View reviewed changes

brancz force-pushed the cut-2.11.0-rc.0 branch 2 times, most recently from 75e76c6 to 00f1e3d Compare July 4, 2019 07:53

simonpasquier reviewed Jul 4, 2019

View reviewed changes

CHANGELOG.md Outdated

@@ -1,3 +1,34 @@

## v2.11.0-rc.0 / 2019-07-04

Copy link

Member

simonpasquier Jul 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/v2.11.0-rc.0/2.11.0-rc.0/

brancz force-pushed the cut-2.11.0-rc.0 branch from 00f1e3d to 480bc87 Compare July 4, 2019 08:06

brian-brazil reviewed Jul 4, 2019

View reviewed changes

Cut v2.11.0-rc.0

dc37d3d

Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>

brancz force-pushed the cut-2.11.0-rc.0 branch from 480bc87 to dc37d3d Compare July 4, 2019 09:04

simonpasquier approved these changes Jul 4, 2019

View reviewed changes

brancz merged commit 5d84b76 into prometheus:master Jul 4, 2019

brancz deleted the cut-2.11.0-rc.0 branch July 4, 2019 11:28

prombot added the benchmark label Jul 4, 2019

prombot removed the benchmark label Jul 8, 2019

prombot added the benchmark label Jul 8, 2019

prombot removed the benchmark label Jul 9, 2019

		@@ -1,3 +1,23 @@
		## v2.11.0-rc.0 / 2019-07-03

		* [CHANGE] Remove max_retries from queue_config. #5649

Cut v2.11.0-rc.0 #5729

Cut v2.11.0-rc.0 #5729

Conversation

brancz commented Jul 2, 2019

brian-brazil left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krasi-georgiev commented Jul 3, 2019

brancz commented Jul 3, 2019

codesome commented Jul 3, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brancz commented Jul 3, 2019

brian-brazil commented Jul 3, 2019

krasi-georgiev commented Jul 3, 2019 • edited

brancz commented Jul 3, 2019

brancz commented Jul 3, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simonpasquier commented Jul 3, 2019

brancz commented Jul 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brian-brazil commented Jul 4, 2019

bwplotka commented Jul 4, 2019

brancz commented Jul 4, 2019

prombot commented Jul 4, 2019

krasi-georgiev commented Jul 8, 2019

krasi-georgiev commented Jul 8, 2019

prombot commented Jul 8, 2019

brancz commented Jul 9, 2019 • edited

krasi-georgiev commented Jul 3, 2019 •

edited

brancz commented Jul 9, 2019 •

edited