promql.ActiveQueryTracker: Unmap mmapped file when done #14000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/query-logger-munmap
branch
3 times, most recently
from
6ecd506
to
fd57350
Compare
aknuds1
force-pushed
the
arve/query-logger-munmap
branch
6 times, most recently
from
a021167
to
0035609
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/query-logger-munmap
branch
from
0035609
to
aabe4d6
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
|
@machine424 I pushed a revision also to fix flakiness in |
machine424
approved these changes
May 23, 2024
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
promql.ActiveQueryTrackerso that it unmaps any mmapped file in itsClosemethod. Also fixTestMMapFileso it releases resources.Related to #13948.