Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed formateoverview section #13994

Merged
merged 5 commits into from May 3, 2024

Conversation

kushalShukla-web
Copy link
Contributor

@kushalShukla-web kushalShukla-web commented Apr 25, 2024

Fix #13975

@kushalShukla-web
Copy link
Contributor Author

@bwplotka

@bboreham
Copy link
Member

Thanks for your contribution, however we need a "DCO sign-off" for your commit.
The method is described here: https://github.com/prometheus/prometheus/pull/13994/checks?check_run_id=24269937908

Signed-off-by: kushagra Shukla <kushalshukla110@gmail.com>
@kushalShukla-web
Copy link
Contributor Author

@bboreham is this looks good ?

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

I've also took the liberty to change your PR description to automatically close the related issue once merged.

Could we just fix this before /?

docs/querying/remote_read_api.md Show resolved Hide resolved
Signed-off-by: Kushal shukla <85934954+kushalShukla-web@users.noreply.github.com>
Signed-off-by: Kushal shukla <85934954+kushalShukla-web@users.noreply.github.com>
Signed-off-by: Kushal shukla <85934954+kushalShukla-web@users.noreply.github.com>
@kushalShukla-web
Copy link
Contributor Author

kushalShukla-web commented May 1, 2024

guys sorry for too many commits .

@bboreham
Copy link
Member

bboreham commented May 2, 2024

It's fine - we can "squash" them all together at merge time.

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
@ArthurSens ArthurSens merged commit d2caf51 into prometheus:main May 3, 2024
25 checks passed
@kushalShukla-web
Copy link
Contributor Author

Thanks @ArthurSens for this latest commit. Eventually, I'm going to do this. By the way, I noticed there are some meetings in community channels, and I tried to join them, but there was no one there. Like today, the meeting was regarding JavaClient. I tried to join it, but it didn't start. This has happened a few times!

@ArthurSens
Copy link
Member

Thanks @ArthurSens for this latest commit. Eventually, I'm going to do this. By the way, I noticed there are some meetings in community channels, and I tried to join them, but there was no one there. Like today, the meeting was regarding JavaClient. I tried to join it, but it didn't start. This has happened a few times!

Oh, sorry to hear that. Most of our meetings have good attendance, but maybe it's worth asking us on Slack a few minutes/hours before the meeting.

I'm not involved in Java community meetings, maybe @fstab has more info?

@kushalShukla-web
Copy link
Contributor Author

i see will ask this in slack .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Remove the section about remote read JSON responses - it only supports proto response or errors
3 participants