Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: storage.md: clarify storage.tsdb.retention.time description #13982

Merged
merged 3 commits into from Apr 29, 2024
Merged

docs: storage.md: clarify storage.tsdb.retention.time description #13982

merged 3 commits into from Apr 29, 2024

Conversation

tesla59
Copy link
Contributor

@tesla59 tesla59 commented Apr 23, 2024

Clarify the content of storage.md, specifically storage.tsdb.retention.time flag.
mentioned here: #13967 (comment)

prometheus/cmd/prometheus/main.go

Lines 345 to 346 in 76b0318

serverOnlyFlag(a, "storage.tsdb.retention.time", "How long to retain samples in storage. When this flag is set it overrides \"storage.tsdb.retention\". If neither this flag nor \"storage.tsdb.retention\" nor \"storage.tsdb.retention.size\" is set, the retention time defaults to "+defaultRetentionString+". Units Supported: y, w, d, h, m, s, ms.").
SetValue(&newFlagRetentionDuration)

@tesla59 tesla59 mentioned this pull request Apr 23, 2024
Open
machine424
machine424 reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@machine424 machine424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits.
Thanks.

docs/storage.md Outdated Show resolved Hide resolved
docs/storage.md Outdated Show resolved Hide resolved
tesla59 and others added 2 commits April 27, 2024 13:50
@tesla59 @machine424
Update docs/storage.md
8013149 
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
Signed-off-by: Nishant Singh <nishant@heim.id>
@tesla59 @machine424
Update docs/storage.md
c8b2398 
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
Signed-off-by: Nishant Singh <nishant@heim.id>
@tesla59
Copy link
Contributor Author

tesla59 commented Apr 27, 2024

Hi @machine424
Appreciate your review.
Made the suggested changes
Thanks

machine424
machine424 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@machine424 machine424 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks again.

ArthurSens
ArthurSens approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArthurSens ArthurSens merged commit 34ee8c6 into prometheus:main Apr 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machine424 machine424 machine424 approved these changes

@ArthurSens ArthurSens ArthurSens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tesla59 @machine424 @ArthurSens