[PRW 2.0] Moved rw2 proto to the full path (both package name and placement) #13973
Conversation
…cement) This is what buf recommends https://buf.build/docs/reference/protobuf-files-and-packages#packages Signed-off-by: bwplotka <bwplotka@gmail.com>
Looks fine to me but I'm not seeing ☝️ this change, which I think you intended to commit (based on your note there but also the changes to the comments in the proto files). |
| // (histograms field), although it should be extremely rare in practice (e.g. | ||
| // only when classic histogram series and native histogram share exactly the | ||
| // same metric name). | ||
| // Timeseries messages can either specify samples or (native) histogram samples | ||
| // (histogram field), but not both. For typical clients (~real-time metric | ||
| // streaming), in healthy cases, there will be only one sample or histogram. | ||
| // | ||
| // Samples are sorted by timestamp (older first). | ||
| // Samples and histograms are sorted by timestamp (older first). | ||
| repeated Sample samples = 2 [(gogoproto.nullable) = false]; | ||
| // histograms contain zero or more histogram samples for a given timeseries. | ||
| // For typical clients, in healthy cases, there will be only one sample, for ~real | ||
| // time metric streaming. histograms can co-exist with samples (see samples | ||
| // for details). | ||
| // | ||
| // histograms are sorted by timestamp (older first). | ||
| repeated Histogram histograms = 3 [(gogoproto.nullable) = false]; |
There was a problem hiding this comment.
Changes to samples & histogram samples behaviour I mentioned.
There was a problem hiding this comment.
|
Those changes are here @cstyan 🤗 https://github.com/prometheus/prometheus/pull/13973/files#r1592219265 |
|
Merging this, we can revert the commentary about samples vs histogram sample semantics later on, adding to our agenda: https://docs.google.com/document/d/1TYKB_XqVgkEZlxosQ9BM0XR8JFi0pctlNQ-gdu1wuRw/edit |
Changes:
github.com/prometheus/prometheus/prompb/io/prometheus/write/v2, soio/prometheus/write/v2package. This is what buf recommends https://buf.build/docs/reference/protobuf-files-and-packages#packages and i shortened it (we will likely never have "local write").