docs: [ovh sd] Added missing label for OVH dedicated server in SD

[jiekun]

__meta_ovhcloud_dedicated_server_no_intervention label is available for OVH Cloud dedicated server. But it's missing in doc.

See:

prometheus/discovery/ovhcloud/dedicated_server.go

Line 149 in da1b7a1

dedicatedServerLabelPrefix + "no_intervention": model.LabelValue(strconv.FormatBool(server.NoIntervention)),

And previous test case:

prometheus/discovery/ovhcloud/dedicated_server_test.go

Line 65 in da1b7a1

"__meta_ovhcloud_dedicated_server_no_intervention": "false",

[jiekun]

@machine424 @roidelapluie Hi May I have your review of this PR? Thanks!

[machine424]

Maybe we should precise whether no_intervention means:

• interventions are disabled on the server.
  OR
• there is no interventions currently on the server.

[jiekun]

Thank you for the review and sorry for my late reply, I was out of the office yesterday.

According to OVH's document, noIntervation refer to:

• Prevent datacenter intervention.

So in this case, it means "interventions are disabled on the server". And I'd like to suggest using the following description:

• is this server immune to datacenter intervention.

WDYT @machine424

[machine424]

thanks.

[machine424]

For the failing DCO job:

Thanks for your PR. For legal reasons, we require that all commits are signed with a DCO before we can merge them. See this blog post for considerations around this.

This means that the last line of your commit message should read like:

Signed-Off-By: Your Name <your@email.address>

If you are using GitHub through the web interface, it's quickest to close this PR and open a new one with the appropriate line.

If you are using Git on the command line, it is probably quickest to amend and force push. You can do that with

git commit --amend --signoff
git push -f $remote $remote_branch_for_pr

As always, be careful when force-pushing.

Originally posted by @roidelapluie

[jiekun]

@machine424 Thanks again. I just fixed it. And sorry for the trouble.