Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add LabelQuerier.LabelValuesStream method #12794

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Add LabelQuerier.LabelValuesStream method #12794

wants to merge 1 commit into from
+1,733 −55

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Sep 5, 2023 •
edited

Add method storage.LabelQuerier.LabelValuesStream that returns an iterator over corresponding label values, instead of a slice.

Work in progress!

TODO:

  • Benchmark
  • Instead of making a sorted values slice, consider copying the postings matching the matchers, before intersecting them with each label value’s posting list, allowing iterating over values in alphabetical order (thanks, @dimitarvdimitrov)
  • Extend test cases to cover relevant corners

@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 5 times, most recently from 9ac2613 to b1bdc7f Compare September 26, 2023 08:48
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 3 times, most recently from 0f7bd50 to 2b3197e Compare October 6, 2023 13:34
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 3 times, most recently from 53dfff1 to f985300 Compare October 21, 2023 12:42
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 2 times, most recently from 65b873e to 105b207 Compare October 31, 2023 15:52
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 3 times, most recently from f1ce814 to 4566980 Compare November 14, 2023 09:28
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 2 times, most recently from a5bdb6f to f250c97 Compare November 21, 2023 16:31
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 4 times, most recently from a6a516d to 29c6a21 Compare December 1, 2023 08:02
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 2 times, most recently from 912e2df to ff5e827 Compare December 7, 2023 07:31
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 3 times, most recently from 57d36a2 to 3ef4992 Compare May 9, 2024 10:01
@aknuds1
Add LabelQuerier.LabelValuesStream method
57e4df6 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roidelapluie roidelapluie Awaiting requested review from roidelapluie roidelapluie will be requested when the pull request is marked ready for review roidelapluie is a code owner

@jesusvazquez jesusvazquez Awaiting requested review from jesusvazquez jesusvazquez will be requested when the pull request is marked ready for review jesusvazquez is a code owner

@cstyan cstyan Awaiting requested review from cstyan cstyan will be requested when the pull request is marked ready for review cstyan is a code owner

@bwplotka bwplotka Awaiting requested review from bwplotka bwplotka will be requested when the pull request is marked ready for review bwplotka is a code owner

@tomwilkie tomwilkie Awaiting requested review from tomwilkie tomwilkie will be requested when the pull request is marked ready for review tomwilkie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aknuds1