Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle error unwrapping in rules and remote write receiver #11727

Merged
merged 1 commit into from Dec 15, 2022
Merged

Correctly handle error unwrapping in rules and remote write receiver #11727

merged 1 commit into from Dec 15, 2022

Commits on Dec 15, 2022

  1. Correctly handle error unwrapping in rules and remote write receiver 

    errors.Unwrap() actually dangerously returns nil if the error does not have an
Unwrap() method, which is the case in at least one of these places where I
noticed that no error was being logged at all when it should have.

Signed-off-by: Julius Volz <julius.volz@gmail.com>
    @juliusv
    juliusv committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1a2c645 View commit details
    Browse the repository at this point in the history