New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promtool: add http config support to query commands #11487
Promtool: add http config support to query commands #11487
Conversation
@dgl would you find a second to review please?:pray: |
Can we move this code to Prometheus/common? |
Which part of the code do you exactly mean to move to the common? The |
yes please |
Actually it appears the function is already there, just in the test files and not used, nor by Alertmanager or Prometheus itself. PR here prometheus/common#415 |
7055828
to
08e3404
Compare
Switched to prometheus/common as agreed after prometheus/common#415 |
08e3404
to
2458f6a
Compare
Rebased, @roidelapluie friendly bump if you would find awhile 🙏 |
2458f6a
to
37a37b7
Compare
Rebased again |
37a37b7
to
ab1d95d
Compare
Rebased, fuzzing seems to be flaky? |
Fuzzing issue #11810 |
Would you consider including |
I have a basic version of If FUSAKLA isn't keen to implement the feature in this PR, I'd be more then happy to follow up with a PR to implement it. |
Hi, sorry for delay. Sure, I'll add the support event for the |
ab1d95d
to
a725e57
Compare
@bboreham PTAL @roidelapluie friendly bump once again 🙏 |
The failing CI seems weird once again 🤔 |
can you run go mod tidy? |
I ran it multiple times locally (go 1.19) and in container (official 1.18) with no changes 🤔 |
I'm not able to reproduce anyhow locally the issues CI bumps into. |
I think there is some general issue with CI - I've seen these error messages on other PRs. |
673f76c
to
b3abb39
Compare
I suspected bump in the golang-builder on Go 1.20, but that seems also not to be an issue… 🤔 |
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
b3abb39
to
3ebe4b4
Compare
🎉 rebased on master and CI passes.. @roidelapluie Would you take a look 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Does not seem to be done |
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
Should be fixed now 🤞 |
Thanks! |
Thank you! 🎉 |
Hi,
as a followup to the previous PR from Alertmanager prometheus/alertmanager#2764 and stale PR for promtool #8082
This PR adds support for HTTP config using the promconfig common package same as amtool does for query subcommands.
Works just fine, tested with base auth and bearer token.
@roidelapluie would you mind taking a look since you were actibe in both above linked PRs? 🙏