Do not lint duplicate rules when checking Prometheus config.

[roidelapluie]

Linting rules by default is a breaking change that broke our users' CI
pipeline with false positive. Let's exclude this by default.

Signed-off-by: Julien Pivotto roidelapluie@o11y.eu

[roidelapluie]

cc @metalmatze can we cherry pick this in 2.36 and issue a new 2.36.1 with the go release update + this ?

[dgl]

Have you got details on what the breakage is? We did previously lint duplicate rules, but potentially the exit code changed... I'm worried if we do this we might break someone else in a different way.

[roidelapluie]

yes, the exit code change is the problem here. we return non zero.

[roidelapluie]

Have you got details on what the breakage is? We did previously lint duplicate rules, but potentially the exit code changed... I'm worried if we do this we might break someone else in a different way.

What would you propose?

[dgl]

What would you propose?

Maybe a --lint-fatal boolean flag to make lint errors exit with a fatal exit code, which can default to off. This should be consistent between check rules and check config (this PR is missing the check rules one at the moment).

Also, it looks like this was introduced in 2.35, not just 2.36.

[dgl]

Implemented my suggestion in #10815