Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PromQL: Promote negative offset and @ modifer to stable #10121

Merged
merged 3 commits into from Jan 12, 2022
Merged

Commits on Jan 10, 2022

  1. PromQL: Promote negative offset and @ modifer to stable

    Following the argument that breaking the invariant that PromQL does
    not look ahead of the evaluation time implies a breaking change, we
    still need to keep the feature flag around, but at least we can
    communicate that the feature is considered stable, and that the
    feature flags will be ignored from v3 on.
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jan 10, 2022
    Copy the full SHA
    61509fc View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. PromQL: Always enable negative offset and @ modifier

    This follows the line of argument that the invariant of not looking
    ahead of the query time was merely emerging behavior and not a
    documented stable feature. Any query that looks ahead of the query
    time was simply invalid before the introduction of the negative offset
    and the @ modifier.
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jan 11, 2022
    Copy the full SHA
    b39f273 View commit details
    Browse the repository at this point in the history
  2. PromQL: Test negative offset in PromQL tests

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jan 11, 2022
    Copy the full SHA
    c2b80d8 View commit details
    Browse the repository at this point in the history