Correctly handle error unwrapping in rules and remote write receiver #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusv
requested review from
csmarchbanks,
cstyan,
bwplotka and
tomwilkie
as code owners
|
can you point this at the release 2.41 branch? |
errors.Unwrap() actually dangerously returns nil if the error does not have an Unwrap() method, which is the case in at least one of these places where I noticed that no error was being logged at all when it should have. Signed-off-by: Julius Volz <julius.volz@gmail.com>
juliusv
force-pushed
the
fix-error-unwrapping
branch
from
d59f721
to
1a2c645
Compare
|
Thanks! |
|
It would be nice to see how you got this because it means we miss basic unit tests |
For my blog post https://promlabs.com/blog/2022/12/15/understanding-duplicate-samples-and-out-of-order-timestamp-errors-in-prometheus I was trying to provoke error logs about out-of-order samples received via remote write, but I didn't see any, so I started digging around in the code. It's currently a bit hard to unit test because the only thing being done in the case of an error is a log output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors.Unwrap()actually dangerously returnsnilif the error does not have anUnwrap()method, which is the case in at least one of these places where I noticed that no error was being logged at all when it should have.Signed-off-by: Julius Volz julius.volz@gmail.com