fix: close file in error handling

Signed-off-by: guoguangwu <guoguangwug@gmail.com>
prometheus · Apr 18, 2024 · 41d41b2 · 41d41b2
1 parent b938bbc
commit 41d41b2
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/promql/query_logger.go b/promql/query_logger.go
@@ -96,12 +96,14 @@ func getMMapedFile(filename string, filesize int, logger log.Logger) ([]byte, io
 
 	err = file.Truncate(int64(filesize))
 	if err != nil {
+		file.Close()
 		level.Error(logger).Log("msg", "Error setting filesize.", "filesize", filesize, "err", err)
 		return nil, nil, err
 	}
 
 	fileAsBytes, err := mmap.Map(file, mmap.RDWR, 0)
 	if err != nil {
+		file.Close()
 		level.Error(logger).Log("msg", "Failed to mmap", "file", filename, "Attempted size", filesize, "err", err)
 		return nil, nil, err
 	}