Revert add avgRTT to nfs mountstats #487 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an artificiality computed value from existing values. The goal of this library is to provide simple raw access to values, rather than pre-compute data. Reverts: #487 Signed-off-by: SuperQ <superq@gmail.com>
ArthurSens
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Hey 👋
I'm not sure why I'm tagged here, I haven't worked on this library before 😬
Looking at #629 I can see you were made a maintainer, so I believe you know what you're doing :) Giving the rubber stamp just in case you need someone to unblock the PR
Unfortunately, I won't have the time to fully understand the impact of this revert, I suggest that other maintainers chime in if you're looking for a longer discussion!
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/procfs](https://togithub.com/prometheus/procfs) | `v0.13.0` -> `v0.14.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/procfs (github.com/prometheus/procfs)</summary> ### [`v0.14.0`](https://togithub.com/prometheus/procfs/releases/tag/v0.14.0) [Compare Source](https://togithub.com/prometheus/procfs/compare/v0.13.0...v0.14.0) #### What's Changed - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/procfs#613 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/procfs#615 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/procfs#616 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/procfs#621 - Revert add avgRTT to nfs mountstats [#​487](https://togithub.com/prometheus/procfs/issues/487) by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/procfs#625 - style: returns procfs build-in error like other parsing methods by [@​weidongkl](https://togithub.com/weidongkl) in [prometheus/procfs#630 - update MAINTAINERS.md by [@​pgier](https://togithub.com/pgier) in [prometheus/procfs#629 - \*: `s/(%v|%s)/%w` and use `go1.20` by [@​rexagod](https://togithub.com/rexagod) in [prometheus/procfs#617 - chore: Use kernel-compliant types for `{U,G}IDs` by [@​rexagod](https://togithub.com/rexagod) in [prometheus/procfs#620 - Update Go versions by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/procfs#632 - fix: same TCP connection appears twice by [@​weidongkl](https://togithub.com/weidongkl) in [prometheus/procfs#631 - Revert "fix: same TCP connection appears twice" by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/procfs#633 #### New Contributors - [@​rexagod](https://togithub.com/rexagod) made their first contribution in [prometheus/procfs#617 **Full Changelog**: prometheus/procfs@v0.13.0...v0.14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…n-telemetry#32636) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/procfs](https://togithub.com/prometheus/procfs) | `v0.13.0` -> `v0.14.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/procfs (github.com/prometheus/procfs)</summary> ### [`v0.14.0`](https://togithub.com/prometheus/procfs/releases/tag/v0.14.0) [Compare Source](https://togithub.com/prometheus/procfs/compare/v0.13.0...v0.14.0) #### What's Changed - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://togithub.com/prombot) in [prometheus/procfs#613 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://togithub.com/prombot) in [prometheus/procfs#615 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://togithub.com/prombot) in [prometheus/procfs#616 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://togithub.com/prombot) in [prometheus/procfs#621 - Revert add avgRTT to nfs mountstats [#&open-telemetry#8203;487](https://togithub.com/prometheus/procfs/issues/487) by [@&open-telemetry#8203;SuperQ](https://togithub.com/SuperQ) in [prometheus/procfs#625 - style: returns procfs build-in error like other parsing methods by [@&open-telemetry#8203;weidongkl](https://togithub.com/weidongkl) in [prometheus/procfs#630 - update MAINTAINERS.md by [@&open-telemetry#8203;pgier](https://togithub.com/pgier) in [prometheus/procfs#629 - \*: `s/(%v|%s)/%w` and use `go1.20` by [@&open-telemetry#8203;rexagod](https://togithub.com/rexagod) in [prometheus/procfs#617 - chore: Use kernel-compliant types for `{U,G}IDs` by [@&open-telemetry#8203;rexagod](https://togithub.com/rexagod) in [prometheus/procfs#620 - Update Go versions by [@&open-telemetry#8203;SuperQ](https://togithub.com/SuperQ) in [prometheus/procfs#632 - fix: same TCP connection appears twice by [@&open-telemetry#8203;weidongkl](https://togithub.com/weidongkl) in [prometheus/procfs#631 - Revert "fix: same TCP connection appears twice" by [@&open-telemetry#8203;SuperQ](https://togithub.com/SuperQ) in [prometheus/procfs#633 #### New Contributors - [@&open-telemetry#8203;rexagod](https://togithub.com/rexagod) made their first contribution in [prometheus/procfs#617 **Full Changelog**: prometheus/procfs@v0.13.0...v0.14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
jlg-io
pushed a commit
to jlg-io/opentelemetry-collector-contrib
that referenced
this pull request
May 14, 2024
](https://renovatebot.com){kind=link}
…n-telemetry#32636) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/procfs](https://togithub.com/prometheus/procfs) | `v0.13.0` -> `v0.14.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/procfs (github.com/prometheus/procfs)</summary> ### [`v0.14.0`](https://togithub.com/prometheus/procfs/releases/tag/v0.14.0) [Compare Source](https://togithub.com/prometheus/procfs/compare/v0.13.0...v0.14.0) #### What's Changed - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://togithub.com/prombot) in [prometheus/procfs#613 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://togithub.com/prombot) in [prometheus/procfs#615 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://togithub.com/prombot) in [prometheus/procfs#616 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://togithub.com/prombot) in [prometheus/procfs#621 - Revert add avgRTT to nfs mountstats [#&open-telemetry#8203;487](https://togithub.com/prometheus/procfs/issues/487) by [@&open-telemetry#8203;SuperQ](https://togithub.com/SuperQ) in [prometheus/procfs#625 - style: returns procfs build-in error like other parsing methods by [@&open-telemetry#8203;weidongkl](https://togithub.com/weidongkl) in [prometheus/procfs#630 - update MAINTAINERS.md by [@&open-telemetry#8203;pgier](https://togithub.com/pgier) in [prometheus/procfs#629 - \*: `s/(%v|%s)/%w` and use `go1.20` by [@&open-telemetry#8203;rexagod](https://togithub.com/rexagod) in [prometheus/procfs#617 - chore: Use kernel-compliant types for `{U,G}IDs` by [@&open-telemetry#8203;rexagod](https://togithub.com/rexagod) in [prometheus/procfs#620 - Update Go versions by [@&open-telemetry#8203;SuperQ](https://togithub.com/SuperQ) in [prometheus/procfs#632 - fix: same TCP connection appears twice by [@&open-telemetry#8203;weidongkl](https://togithub.com/weidongkl) in [prometheus/procfs#631 - Revert "fix: same TCP connection appears twice" by [@&open-telemetry#8203;SuperQ](https://togithub.com/SuperQ) in [prometheus/procfs#633 #### New Contributors - [@&open-telemetry#8203;rexagod](https://togithub.com/rexagod) made their first contribution in [prometheus/procfs#617 **Full Changelog**: prometheus/procfs@v0.13.0...v0.14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an artificiality computed value from existing values. The goal of this library is to provide simple raw access to values, rather than pre-compute data.
Reverts: #487