Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: s/(%v|%s)/%w and use go1.20 #617

Merged
merged 3 commits into from
Apr 10, 2024
Merged

*: s/(%v|%s)/%w and use go1.20 #617

merged 3 commits into from
Apr 10, 2024

Commits on Mar 21, 2024

  1. *: s/(%v|%s)/%w for all fmt.Errorf errors 

    The `%w` verb was introduced in `go1.20` which allows for error
wrapping. However, even though the minimum supported version was
specified as `go1.19` there are already sparse occurences of the `%w`
verb throughout the codebase. Hence it's safe to move the minimum
supported version to `go1.20` since its constructs have been in use
within the repository for a while now.

Refer: https://go.dev/doc/go1.20#errors
Fixes: prometheus#519
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
    @rexagod
    rexagod committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    d559fd9 View commit details
    Browse the repository at this point in the history

  2. chore: Specify minimum Golang version as 1.20 

    PTAL at the previous commit (d559fd9) for more details.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
    @rexagod
    rexagod committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    bc79f98 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. fixup! chore: Specify minimum Golang version as 1.20 

    Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
    @rexagod
    rexagod committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    bde520a View commit details
    Browse the repository at this point in the history