net class: split out attribute parser and export it #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbw
force-pushed
the
ParseSysfsNetClassAttribute
branch
from
f5d56b4
to
a62ecc0
Compare
dcbw
force-pushed
the
ParseSysfsNetClassAttribute
branch
from
a62ecc0
to
7b879a0
Compare
|
@discordianfish is this what you were thinking of? |
Can be used by other projects (eg node_exporter) to read a single sysfs file rather than all of them at once, which can cause lock contention in the kernel as many sysfs net files grab the RTNL lock. Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw
force-pushed
the
ParseSysfsNetClassAttribute
branch
from
7b879a0
to
03e2a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used by other projects (eg node_exporter) to read a single sysfs file rather than all of them at once, which can cause lock contention in the kernel as many sysfs net files grab the RTNL lock.
Immediate consumer: prometheus/node_exporter#2669