Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate /proc/stat parsing logic #474

Merged
merged 1 commit into from Dec 17, 2022
Merged

Separate /proc/stat parsing logic #474

merged 1 commit into from Dec 17, 2022

Conversation

Dentrax
Copy link
Contributor

@Dentrax Dentrax commented Oct 29, 2022

Signed-off-by: Furkan furkan.turkal@trendyol.com

Same motivation as PR #472

@Dentrax
Separate /proc/stat parsing logic
045a006 
Signed-off-by: Furkan <furkan.turkal@trendyol.com>
discordianfish
discordianfish approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks! LGTM.

@Dentrax Dentrax mentioned this pull request Nov 4, 2022
Open
4 tasks
SuperQ
SuperQ approved these changes Dec 17, 2022
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also same, let's make the parsing public.

@SuperQ SuperQ merged commit 945097a into prometheus:master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discordianfish discordianfish discordianfish approved these changes

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dentrax @discordianfish @SuperQ