Replace float64 with *float64 for proc_netstat, proc_snmp and proc_snmp6 #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like your procfs branch is out of date. Also, you need to setup a global gitignore. |
|
Please also either link to an issue, or include a description about why you are making changes. |
nikakis
force-pushed
the
replace-float64-with-pointer-for-proc-netstat-snmp-and-snmp6
branch
4 times, most recently
from
1109ce9
to
b13676a
Compare
Signed-off-by: Nikos Kakavas <nikakis@protonmail.com>
nikakis
force-pushed
the
replace-float64-with-pointer-for-proc-netstat-snmp-and-snmp6
branch
from
b13676a
to
cf0ef0d
Compare
|
@SuperQ Any idea about how i should proceed with the |
|
Looks like the codespell issues are unrelated. They can be ignored. |
Ok, so I am waiting for an approval from your side, right? |
|
@SuperQ Does this looks good to you? Can we merge it? |
SuperQ
approved these changes
Sep 24, 2022
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
…mp6 (prometheus#464) Signed-off-by: Nikos Kakavas <nikakis@protonmail.com> Signed-off-by: Nikos Kakavas <nikakis@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to this issue #434 which is needed for prometheus/node_exporter#2336
Signed-off-by: Nikos Kakavas nikakis@protonmail.com