Add support for several /sys/class/sas_* classes #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These parse several SAS classes from /sys/class/ - sas_host - sas_device - sas_end_device - sas_expander - sas_port - sas_phy The included fixtures include examples of all of these. Signed-off-by: Scott Laird <scott@sigkill.org>
… SAS device address to /dev/sd*. Note that the fixtures for this rev are still *way* too big; fixtures.ttar went from ~300k to 11M. Cleaning that up is next. Signed-off-by: Scott Laird <scott@sigkill.org>
Still about 2x larger than before, but *much* better than the previous commit. There's a lot of additional SAS data included in /sys/devices, and there's a limit to how much smaller it can get without a lot of work and lost data. Signed-off-by: Scott Laird <scott@sigkill.org>
I refactored the 3 different /sys/class entries in class_sas_device, because they're almost exactly the same except for the directory name and which devices are included in the directory. Signed-off-by: Scott Laird <scott@sigkill.org>
|
Some minor comments but LGTM in general. Thanks! |
Signed-off-by: Scott Laird <scott@sigkill.org>
We weren't populating a couple fields due to dumb errors. Also, I'd failed to add end_device to SASPort, which is needed for block device discovery. Signed-off-by: Scott Laird <scott@sigkill.org>
|
I started writing my |
…n code that uses this library. Signed-off-by: Scott Laird <scott@sigkill.org>
|
Okay, that ended up being bigger than expected. OTOH, the |
|
@discordianfish want to take another look? |
|
@SuperQ any chance this could get a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for several SAS classes from
/sys/class:sas_hostsas_devicesas_end_devicesas_expandersas_physas_portThese are for issue #452, which is needed for prometheus/node_exporter#2386. Once that is complete, it'll be possible to track SAS communication errors on each individual SAS link in a system, and then map those links to specific block devices.
Use case: I recently discovered that I had a bad SAS cable in my system and was seeing weird, intermittent disk timeouts and errors which caused ZFS problems. Being able to track SAS issues for each node should make detecting and debugging this sort of problem much easier.