Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing name to the *testing.T argument. #425

Merged
merged 1 commit into from Dec 13, 2021
Merged

Add a missing name to the *testing.T argument. #425

merged 1 commit into from Dec 13, 2021

Commits on Dec 11, 2021

  1. Add a missing name to the *testing.T argument. 

    When using t.Run, the subtest must take a named *testing.T argument. Otherwise, inner calls to t.Error etc. are invoked on the outer test object, which is pretty much always wrong.

Signed-off-by: Matt Harden <matt.harden@gmail.com>
    @nerdatmath
    nerdatmath committed Dec 11, 2021
    Copy the full SHA
    9b10892 View commit details
    Browse the repository at this point in the history