Fix data types for ignored stat fields #401 #402
Conversation
Some ignored fields in the /proc/[pid]/stat file may have values that are bigger than the max value of the current Go type that is used for the ignored variable. That leads to issues in runtime on some systems that use the maximum possible values for the related fields. See for details: * https://man7.org/linux/man-pages/man5/proc.5.html * https://man7.org/linux/man-pages/man3/scanf.3.html Signed-off-by: Vyacheslav Kulakov <kulakov.home@gmail.com>
|
The interesting thing here is that the fixtures already have examples of the stat file that cannot pass tests but they. Unfortunately, haven't been used in the stat related tests. |
Should we deal with other fields then? Not in this PR of course. I guess it will break compatibility but such change may be a good candidate for a release (1.x.x I mean). |
|
This library is still pre 1.0. So, we can add breaking changes pretty easily. |
Please, check #403 and let me know if the mailing lists are a better place for such things. Thanks. |
|
@vykulakov github issues are best (unless it's help/usage questions etc), so thanks for filling! |
|
Thank you! Can you tell me if there is going to be a bugfix release for this? |
|
Hi I suspect this is causing a crash on startup for arm64 MacOS. This is the only change that went into 1.2.2 of see |
Some ignored fields in the
/proc/[pid]/statfile may have values that are bigger than the max value of the current Go type that is used for the ignored variable. That leads to issues in runtime on some systems that use the maximum possible values for the related fields.Please note, that this PR fixes data types only for the ignored fields. Other fields in the stat file may be still affected especially on nodes that use 32-bit arch.
@pgier @discordianfish please have a look.
See for details:
Fixes: #401
Signed-off-by: Vyacheslav Kulakov kulakov.home@gmail.com