Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for /proc/<algod PID>/net/snmp and /proc/uptime #434

Closed
nikakis opened this issue Feb 13, 2022 · 6 comments
Closed

Introduce support for /proc/<algod PID>/net/snmp and /proc/uptime #434

nikakis opened this issue Feb 13, 2022 · 6 comments

Comments

@nikakis
Copy link
Contributor

nikakis commented Feb 13, 2022

Hello guys!
Would you consider a PR for enhancing support for /proc/<algod PID>/net/snmp and /proc/uptime?
Thanks!!!

@SuperQ
Copy link
Member

SuperQ commented Feb 13, 2022

There's already BootTime() from /proc/stat, so /proc/uptime isn't as necessary.

Adding a parser for net/snmp would be useful. We currently have an old parser in the node_exporter, It would be nice to migrate that to this codebase like we have been doing with other parsers.

@nikakis
Copy link
Contributor Author

nikakis commented Feb 13, 2022

Ok great!!!
I will do the migration @SuperQ.
Probably i can also add netstat and snmp6.
Is there any reference from a similar migration or can you give me a hint? Just to be sure that i will be working in the right direction.
Thanks!!!

@SuperQ
Copy link
Member

SuperQ commented Feb 13, 2022

Take a look at the PR history in this repo, there are lots of good examples.

@nikakis
Copy link
Contributor Author

nikakis commented Feb 14, 2022

@SuperQ Please have a first look in the PR.
Thanks!!!

@nikakis
Copy link
Contributor Author

nikakis commented Apr 3, 2022

I think this issue can be closed. The implementation is done in this PR

@discordianfish
Copy link
Member

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants