Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert %w verb in t.Errorf function to %v #431

Merged
merged 1 commit into from Jan 21, 2022

Conversation

eclipseo
Copy link
Contributor

Go 1.18 introduced a change where only fmt.Errorf function accepts the %w verb.
Other Errorf function like t.Errorf do not accept it anymore.

See golang/go#47641

Fix: #430

@SuperQ
Copy link
Member

SuperQ commented Jan 14, 2022

Thanks!

This needs a DCO sign-off. You can use git commit -s --amend to add it.

Go 1.18 introduced a change where only fmt.Errorf function accepts the %w verb.
Other Errorf function like t.Errorf do not accept it anymore.

See golang/go#47641

Fix: prometheus#430

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
@eclipseo
Copy link
Contributor Author

Added signoff.
Thanks.

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.18: Errorf does not support error-wrapping directive %w
3 participants