Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TOC members: add dsimansk and zroubalik #1090

Merged
merged 2 commits into from Jun 9, 2022
Merged

Update TOC members: add dsimansk and zroubalik #1090

merged 2 commits into from Jun 9, 2022

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Jun 7, 2022 •
edited

Changes

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2022
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2022
@zroubalik
Copy link
Contributor Author

/hold for input from David

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@zroubalik
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@dprotaso
Copy link
Member

dprotaso commented Jun 8, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@knative-prow
Copy link

knative-prow bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@dprotaso
Copy link
Member

dprotaso commented Jun 8, 2022

/assign @lance @vaikas
/unassign @dprotaso

@knative-prow knative-prow bot assigned lance and vaikas and unassigned dprotaso Jun 8, 2022
@dprotaso
Copy link
Member

dprotaso commented Jun 8, 2022

cc @upodroid looks like a bug in the groups tool?

@upodroid
Copy link
Member

upodroid commented Jun 8, 2022

you bumped the go version, i'll need to take a look

@upodroid
Copy link
Member

upodroid commented Jun 8, 2022

Identified the cause prometheus/procfs#431 will push a fix in a separate PR.

@upodroid upodroid mentioned this pull request Jun 8, 2022
Merged
@vaikas
Copy link
Contributor

vaikas commented Jun 9, 2022

/test pull-knativeteam-groups-test

Hoping now that #1095 has been merged things will work :)

@knative-prow knative-prow bot merged commit 5ea2cd5 into knative:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk dsimansk left review comments

Assignees

@lance lance

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zroubalik @dprotaso @upodroid @vaikas @dsimansk @lance