Skip to content

Commit

Permalink
Revert "add avgRTT to nfs mountstats"
Browse files Browse the repository at this point in the history
  • Loading branch information
SuperQ committed Mar 28, 2024
1 parent c5ada8d commit 8498390
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
6 changes: 1 addition & 5 deletions mountstats.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,6 @@ type NFSOperationStats struct {
CumulativeTotalResponseMilliseconds uint64
// Duration from when a request was enqueued to when it was completely handled.
CumulativeTotalRequestMilliseconds uint64
// The average time from the point the client sends RPC requests until it receives the response.
AverageRTTMilliseconds float64
// The count of operations that complete with tk_status < 0. These statuses usually indicate error conditions.
Errors uint64
}
Expand Down Expand Up @@ -571,6 +569,7 @@ func parseNFSOperationStats(s *bufio.Scanner) ([]NFSOperationStats, error) {

ns = append(ns, n)
}

opStats := NFSOperationStats{
Operation: strings.TrimSuffix(ss[0], ":"),
Requests: ns[0],
Expand All @@ -582,9 +581,6 @@ func parseNFSOperationStats(s *bufio.Scanner) ([]NFSOperationStats, error) {
CumulativeTotalResponseMilliseconds: ns[6],
CumulativeTotalRequestMilliseconds: ns[7],
}
if ns[0] != 0 {
opStats.AverageRTTMilliseconds = float64(ns[6]) / float64(ns[0])
}

if len(ns) > 8 {
opStats.Errors = ns[8]
Expand Down
2 changes: 0 additions & 2 deletions mountstats_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ func TestMountStats(t *testing.T) {
CumulativeQueueMilliseconds: 6,
CumulativeTotalResponseMilliseconds: 79386,
CumulativeTotalRequestMilliseconds: 79407,
AverageRTTMilliseconds: 61.16024653312789,
},
{
Operation: "WRITE",
Expand All @@ -353,7 +352,6 @@ func TestMountStats(t *testing.T) {
CumulativeQueueMilliseconds: 18446743919241604546,
CumulativeTotalResponseMilliseconds: 1667369447,
CumulativeTotalRequestMilliseconds: 1953587717,
AverageRTTMilliseconds: 0.5695744656983355,
},
},
Transport: NFSTransportStats{
Expand Down

0 comments on commit 8498390

Please sign in to comment.