udp_queues_linux.go: Expose UDP drops via gauge analogous to queue sizes #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleeland
force-pushed
the
expose-udp-drops
branch
2 times, most recently
from
084bd27
to
b297b22
Compare
|
@discordianfish @SuperQ I'm assuming that the failing circleci tests are because I need to update the fixtures (via |
Ensure identical build flags embedded in both files. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
…zes. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
cleeland
force-pushed
the
expose-udp-drops
branch
from
b297b22
to
271bcee
Compare
Update e2e test output to include the drops. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
|
I'm not sure why |
Don't use a pointer without checking it first. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
SuperQ
requested changes
Apr 22, 2024
Drat; you're right. Let me see if I can fix this quickly. |
I think it makes sense for "drops" to sit alongside the queue length gauges in prom stats because they are all neighbors in procfs (source of these stats). Moreover, in reading the commit log message for the original creating work for udp_queues, I think there may have been some misreading or confusion between the word "state" and the common short-form of "stats" to mean "statistics". The original author "chose the name 'udp_queue' instead of 'udpstat' as UDP has no state"; I believe that 'udpstat' might actually be the more appropriate name. Signed-off-by: Chris Cleeland <chris.cleeland@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a common reason for monitoring UDP queue sizes can be in teasing out performance and QoS issues, it would be convenient to have drops available in the same frames of data. Since the underlying source of the data provides that information, this PR exposes drops modeled as a gauge just as queue sizes are.
@discordianfish @SuperQ