Add node_filesystem_mount_info metric #2970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: prometheus#1384 Signed-off-by: Miguel Oliveira <miguel.oliveira4224@gmail.com>
Signed-off-by: Miguel Oliveira <miguel.oliveira4224@gmail.com>
Signed-off-by: Miguel Oliveira <miguel.oliveira4224@gmail.com>
|
@SuperQ I think this makes sense. I'm a bit confused why the e2e test doesn't fail due to the new metric though? |
|
I took a look at the pipeline and I think the output coming from end to end test script is not being used for some comparison. Maybe check metrics script should have been used after end to end test script ran? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount info is now fetched from
/proc/1/mountinfo(falling back to/proc/self/mountinfo), which contains strictly more information than/proc/1/mounts. This closes #1384 and introduces a workaround to #885 by letting the user join on major and minor fields.