collector/filesystem: s/MNT_NOWAIT/MNT_WAIT
#2960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexagod
force-pushed
the
1498
branch
2 times, most recently
from
d9f495a
to
514d009
Compare
`getfsstat(2)` spec mentions that using `MNT_NOWAIT` will return the information it has available without requesting an update from each file system. Hence, use `MNT_WAIT` in place of the earlier used mode, and make changes to the affected collectors to avoid being stuck for long intervals. Fixes: prometheus#1498 Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
|
I wonder if we could refactor the timeout logic implemented in https://github.com/prometheus/node_exporter/pull/997/files and re-use it here? |
|
@discordianfish Sure! Do you think it'd be better to do that in a separate PR? |
|
@rexagod I think you can just do it here and use to to address the MNT_WAIT change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getfsstat(2)spec mentions that usingMNT_NOWAITwill return the information it has available without requesting an update from each file system. Hence, useMNT_WAITin place of the earlier used mode, and make changes to the affected collectors to avoid being stuck for long intervals.Fixes: #1498