Add a collector for /proc/key-users #2786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzimmerman
force-pushed
the
proc-key-users
branch
2 times, most recently
from
c60d0ec
to
2727703
Compare
|
Fixed a typo in the unit tests |
This collects usage information (per-user) on the Linux kernel keyring See: https://man7.org/linux/man-pages/man7/keyrings.7.html It is disabled by default because cardinality is one-per user. Signed-off-by: Robert Zimmerman <rzimmerman@cloudflare.com>
rzimmerman
force-pushed
the
proc-key-users
branch
from
2727703
to
4b0986f
Compare
SuperQ
requested changes
Sep 9, 2023
| } | ||
|
|
||
| func (c *keyUsersCollector) getKeyUsers() (map[keyUsersEntry]float64, error) { | ||
| file, err := os.Open(procFilePath("key-users")) |
There was a problem hiding this comment.
Parsing files in /proc is something we do in https://github.com/prometheus/procfs first. Please implement parsing there before adding this to the exporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collects usage information (per-user) on the Linux kernel keyring
See: https://man7.org/linux/man-pages/man7/keyrings.7.html
It is disabled by default because cardinality is one per-user.
I was going to do a custom scrape for this but I think it fits in the broader /proc scrape world and may be useful.
@SuperQ @discordianfish