Add tcpstat connection states per source/dest ports #2785
Conversation
Signed-off-by: Tomáš Kadaně <tomas.kadane@cdn77.com>
tomachine
force-pushed
the
tcpstat-states-per-ports
branch
from
67bb15b
to
4e094ea
Compare
| @@ -75,6 +84,11 @@ func NewTCPStatCollector(logger log.Logger) (Collector, error) { | |||
| "Number of connection states.", | |||
| []string{"state"}, nil, | |||
| ), prometheus.GaugeValue}, | |||
| descPort: typedDesc{prometheus.NewDesc( | |||
There was a problem hiding this comment.
This should probably not be a separate metric, but rather change the labels for the existing metric depending on the flag.
There was a problem hiding this comment.
I'm not sure how to implement this. The new metric is working per source/dest port, that is being described by labels "type" and "port". Based on your comment, the solution should be one metric that based on the flags should contain the labels or not? The prometheus library won't allow me to do so. Can you please explain further, how you mean it? thanks
There was a problem hiding this comment.
@SuperQ Hi, can I ask you about the implementation? We need to have the metrics and I would like to finish the MR, thanks:)
|
This is (will be) really cool @tomachine ! |
Added new metric to tcpstats collector, as requested here #2490.