Flesh out bonding fixtures #2347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of change prometheus/procfs#439, update fixtures in node_exporter to expose all referenced interfaces in /sys/class/net This was naively accomplished by blindly copying eth0 data to other physical interfaces, but that does not appear to have resulted in any failing tests. Once we begin to actually export bonding/LACP metrics, additional modification of fixtures may be required. Signed-off-by: Brandon Ewing <brandon.ewing@warningg.com>
bewing
force-pushed
the
bonding_fixtures
branch
from
930ce96
to
bb976b9
Compare
|
Looks like I will have to update e2e fixtures, which means I might as well go ahead and unique-ify the fixtures now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of change prometheus/procfs#439, update fixtures in
node_exporter to expose all referenced interfaces in
/sys/class/netThis was naively accomplished by blindly copying eth0 data to other
physical interfaces, but that does not appear to have resulted in any
failing tests. Once we begin to actually export bonding/LACP metrics,
additional modification of fixtures may be required.