Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace netstat parsers with procfs netstat parsers #2336

Open
nikakis opened this issue Apr 3, 2022 · 8 comments
Open

Replace netstat parsers with procfs netstat parsers #2336

nikakis opened this issue Apr 3, 2022 · 8 comments

Comments

@nikakis
Copy link

nikakis commented Apr 3, 2022

Replace this parsers in node exporter with this ones from procfs.

@nikakis
Copy link
Author

nikakis commented Apr 5, 2022

@discordianfish Can you please assign this to me, i will start working on it asap.

@nikakis
Copy link
Author

nikakis commented May 3, 2022

@discordianfish @SuperQ I think we should consider refactoring the types of the metrics on the procfs side here, here and here from float64 to *float64 because we need to have a value only for the metrics provided by the current system. And afterwards check on the node_exporter side here if the value is not nil and feed it to the channel.

What do you think about this?

@discordianfish
Copy link
Member

I think this is reasonable

@jcpunk
Copy link

jcpunk commented Nov 16, 2022

Any progress on getting this resolved?

@nikakis
Copy link
Author

nikakis commented Nov 17, 2022

@jcpunk Yes, I will work on it during the next days.

@guerzon
Copy link

guerzon commented Nov 5, 2023

Hey @nikakis, any chance I can take this issue? I would like to give this a shot.

@SuperQ
Copy link
Member

SuperQ commented Nov 5, 2023

Go for it.

@exitflynn
Copy link

hi, i've been exploring and using prometheus exporters as of late and would love to contribute some fixes etc to this project (learning stuff along the way). I think no one's actively working on this issue right now and would like to take this up.

I have a question about this issue tho: I've looked into the relevant parts of both the codebases and read up about the proc filesystem and it seems like the mentioned prometheus/procfs netstat parsers currently require a PID and are process specific, as in they're only made to parse /proc/<pid>/net/netstat and not the overall /proc/net/netstat which is what the node_exporter currently uses. And I think these two can vary if the process is in a different network namespace?

p.s. this is my first time learning about these concepts and contributing to Golang / cloud projects in general so there are chances I might've missed something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants