FIX: use sysfs to determine actual sector size for each disk

Signed-off-by: Vasilii Alferov <vasilii@cloudflare.com>
prometheus · Mar 19, 2021 · 54c2ed0 · 54c2ed0
1 parent e026f0f
commit 54c2ed0
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/collector/diskstats_sysfs.go b/collector/diskstats_sysfs.go
@@ -225,12 +225,6 @@ type sysfsDiskCollector struct {
 }
 
 func (m *metric) mustNewConstMetric() prometheus.Metric {
-	switch conv := m.Desc.Conv; conv {
-	case Ms:
-		m.Value = m.Value / 1000.0
-	case Sectors:
-		m.Value = m.Value * DefaultSectorSize
-	}
 	promMetric := prometheus.MustNewConstMetric(
 		prometheus.NewDesc(
 			prometheus.BuildFQName(namespace, diskSubsystem, m.Desc.Name),
@@ -413,6 +407,13 @@ func (c *sysfsDiskCollector) getDeviceStats(d *dmDevice) ([]metric, error) {
 			break
 		}
 
+		switch conv := metricDescs[i].Conv; conv {
+		case Ms:
+			v = v / 1000.0
+		case Sectors:
+			v = v * d.SectorSize
+		}
+
 		m = append(m, metric{
 			Desc:        &metricDescs[i],
 			Value:       v,